To: Paul Traina cc: Bill Fenner , vjs@_ERASE_mica.denver.sgi.com Subject: Re: 1836 From: Julian H. Stacey Hi Paul CC Bill, vjs@_ERASE_mica.denver.sgi.com If vjs would be amenable to changing `punt' in `routed' to Bill's `ignore' or something similar, that would make it more internationaly understandable IMO :-) I hadn't realised routed was maintained externaly to FreeBSD, & by who (vjs), else I'd have sent the suggestion direct to author, Thanks for catching this Paul :-) I don't know if the Hacker's dictionary is an American or British publication ? (I don't have one) or Australian, or from one of the other many English speaking countries ? All I know is I (English) & the Penguin English Dictionary ('85) didn't recognise `punt'. The Hacker's dictionary is something most German computer people of my acquaintance don't have, they just have English/German dictionaries etc) I'm not clear from your 2 replies Paul, whether youve already forwarded this suggestion to vjs@_ERASE_mica.denver.sgi.com or not ? So I've cc'd him, Reference: > From: Paul Traina > Subject: Re: 1836 > Date: Fri, 18 Oct 1996 10:43:53 -0700 (PDT) > Message-id: <199610181743.KAA10909@_ERASE_freefall.freebsd.org> > > In any case, this is externally maintained software, so this patch should NOT > be applied because it does not fix any real problems in the code. Julian, > perhaps you should submit it to vjs@_ERASE_mica.denver.sgi.com. However, I will > warn you in advance that "PUNT" is an international word and is legitimately > used in this case: > > >From the Hacker's dictionary: > > PUNT [from the punch line of an old joke: "Drop back 15 yards and punt"] > v. To give up, typically without any intention of retrying. > & Ref. > From: Paul Traina > To: jhs@, pst, freebsd-bugs > Subject: Re: bin/1836 > > Synopsis: Punt is american only, use abort. > > State-Changed-From-To: open-closed > State-Changed-By: pst > State-Changed-When: Fri Oct 18 10:46:12 PDT 1996 > State-Changed-Why: > Change request submitted to author. If he wants to do it, great, if he > doesn't, we shouldn't be making these kinds of changes to 3rd party code. & Ref. > To: jhs@ > Cc: FreeBSD-gnats-submit@_ERASE_freebsd.org > Subject: Re: bin/1836: /usr/src/*/routed/table.c: s/punt/abort/g > Date: Fri, 18 Oct 1996 10:09:13 PDT > From: Bill Fenner > > I think "ignore" is what is really meant in all of these places. > > Bill & ref. My original > Date: Fri, 18 Oct 1996 07:20:10 -0700 (PDT) > To: jhs@ > From: FreeBSD-gnats@_ERASE_freefall.FreeBSD.org > Subject: Re: bin/1836: /usr/src/*/routed/table.c: s/punt/abort/g > > Thank you very much for your problem report. > It has the internal identification `bin/1836'. > The individual assigned to look at your > bug is: freebsd-bugs. > > >Category: bin > >Responsible: freebsd-bugs > >Synopsis: Punt is american only, use abort. > >Arrival-Date: Fri Oct 18 07:20:09 PDT 1996 > > ------- >> Sent 961016 >> >> To: FreeBSD-gnats-submit@_ERASE_freebsd.org >> cc: jhs@ >> Subject: /usr/src/*/routed/table.c: s/punt/abort/g >> From: jhs@ >> Reply-To: jhs@ >> X-send-pr-version: 3.2 >> >> >> >Submitter-Id: current-users >> >Originator: Julian Stacey jhs@ >> >Organization: Julian Stacey jhs@ >> >Confidential: no >> >Synopsis: Punt is american only, use abort. >> >Severity: non-critical >> >Priority: low >> >Category: bin >> >Release: FreeBSD 2.2-CURRENT i386 >> >Class: change-request >> >Environment: Current >> >> >Description: >> >> Routed American not understandable in English. >> >> /usr/src/*/routed/table.c >> creates console messages like this: >> Oct 16 13:10:46 vector routed[63]: punt RTM_LOSING without gateway >> >> That's not English (I am :-) >> `punt' >> in the Penguin English Dictionary ('85-86) refers to a verb & noun: >> to punt (propel) a punt (flat bottom boat) on a river (or fen). >> `punt' >> in American (according to Jordan, years ago, so forgive any inaccuracy): >> to abandon or give up on something, or decline an invitation >> >> The message is obscure, >> a more globaly understandable word would be better, patch follows >> (feel free to choose a better American to global English translation >> than mine, I don't know what `punt' is except by hearsay, >> but `abort' is nearly as short :-) >> >> >> >How-To-Repeat: >> >> Run current, drop modem slip link >> >> >Fix: >> >> >> ========= Next bit still needs to be done to align with commited changes now commented out further below. *** old/src/sbin/routed/table.c Wed Oct 16 16:10:35 1996 --- new/src/sbin/routed/table.c Wed Oct 16 16:11:37 1996 *************** *** 281,287 **** NTOHL(dst); ! /* Punt non-contiguous subnet masks. * * (X & -X) contains a single bit if and only if X is a power of 2. * (X + (X & -X)) == 0 if and only if X is a power of 2. --- 281,287 ---- NTOHL(dst); ! /* Ignore non-contiguous subnet masks. * * (X & -X) contains a single bit if and only if X is a power of 2. * (X + (X & -X)) == 0 if and only if X is a power of 2. #NOW Done *************** #NOW Done *** 831,844 **** #NOW Done } else if (INFO_MASK(info) != 0) { #NOW Done mask = ntohl(S_ADDR(INFO_MASK(info))); #NOW Done } else { #NOW Done ! msglog("punt %s without mask", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done #NOW Done if (INFO_GATE(info) == 0 #NOW Done || INFO_GATE(info)->sa_family != AF_INET) { #NOW Done ! msglog("punt %s without gateway", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done --- 831,844 ---- #NOW Done } else if (INFO_MASK(info) != 0) { #NOW Done mask = ntohl(S_ADDR(INFO_MASK(info))); #NOW Done } else { #NOW Done ! msglog("abort %s without mask", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done #NOW Done if (INFO_GATE(info) == 0 #NOW Done || INFO_GATE(info)->sa_family != AF_INET) { #NOW Done ! msglog("abort %s without gateway", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done *************** #NOW Done *** 916,922 **** #NOW Done { #NOW Done if (INFO_GATE(info) == 0 #NOW Done || INFO_GATE(info)->sa_family != AF_INET) { #NOW Done ! msglog("punt %s without gateway", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done --- 916,922 ---- #NOW Done { #NOW Done if (INFO_GATE(info) == 0 #NOW Done || INFO_GATE(info)->sa_family != AF_INET) { #NOW Done ! msglog("abort %s without gateway", #NOW Done rtm_type_name(rtm->rtm_type)); #NOW Done return; #NOW Done } #NOW Done >> ========= Julian -- Julian H. Stacey jhs@